Yes, they were golden years:
Economic: After a rocky start, the economy got a real boost. The Dawes Plan brought in foreign investments and helped get things back on track
Political: Politics became more stable, with Gustav Stresemann and parties supporting the Republic keeping things fairly balanced
Foreign Policy: Germany was welcomed back into the international community, even joining the League of Nations
Art and Culture: It was an exciting time for arts and culture - think of the Bauhaus movement and the thriving nightlife in Berlin
No, they weren't:
Despite the surface level progress, it wasn't as rosy as it looked. The economy was dependent on foreign loans, making it shaky. Political extremism was just under the surface, threatening stability. Also, a lot of people felt betrayed by the Treaty of Versailles and the cultural changes were too much for some, leading to societal divisions