I would say the following:
1) access to food and water. This means that they should be next to water sources (rivers) and fertile ground
2) construction material: wood and/or stones
I would say that a location on a trade route would also be beneficial (and rivers were trade routes: this explains why so many cities were on rivers!)