Hello!
your answer is:
Men suffered from lack of rest, rats, disease, and trench foot from living in the trenches.
Unfortunately, these were negative effects. however, trenches did provide cover from gunfire, and gave soldiers extra time to put on gas masks during gas attacks.
I hope this helps, and have a nice day!